fix(ts): mark .getAll() as optional (vercel#262)

* fix(ts): mark `.getAll` as optional * add changelog
jridgewell · Jun 23, 2023 · 085cd3a · 085cd3a
1 parent aaaa759
commit 085cd3a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/.changeset/twenty-dancers-swim.md b/.changeset/twenty-dancers-swim.md
@@ -0,0 +1,6 @@
+---
+'@edge-runtime/node-utils': patch
+'@edge-runtime/primitives': patch
+---
+
+We are already falling back in code, the types just need to reflect this correctly
diff --git a/packages/node-utils/src/edge-to-node/headers.ts b/packages/node-utils/src/edge-to-node/headers.ts
@@ -12,9 +12,7 @@ export function toOutgoingHeaders(
       outputHeaders[name] = value
       if (name.toLowerCase() === 'set-cookie') {
         outputHeaders[name] =
-          'getAll' in headers
-            ? headers.getAll('set-cookie')
-            : splitCookiesString(value)
+          headers.getAll?.('set-cookie') ?? splitCookiesString(value)
       }
     }
   }

diff --git a/packages/primitives/type-definitions/fetch.d.ts b/packages/primitives/type-definitions/fetch.d.ts
@@ -1,5 +1,5 @@
 export class Headers extends globalThis.Headers {
-  getAll(key: 'set-cookie'): string[]
+  getAll?(key: 'set-cookie'): string[]
 }
 
 export class Request extends globalThis.Request {