Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OSX CD build #148

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Fix OSX CD build #148

merged 2 commits into from
Jan 17, 2023

Conversation

dmalec
Copy link
Collaborator

@dmalec dmalec commented Jan 17, 2023

The OSX CD build started producing executables which will not run on OSX 10. systems. My working hypothesis is:

  1. GitHub has largely moved the macOS-latest build machines to macOS-12 already.
  2. OSX 12 needs to have -mmacosx-version-min set to 10.x for compiling and linking in order to produce an executable for 10.x.
  3. This can be done as a side effect of compiling wxWidgets with --with-macosx-version-min=10.x and then using that version of wxWidgets macros during configuration of ucblogo.
  4. This can also be done by explicitly setting -mmacosx-version-min=10.x prior to compiling logo.

This PR includes two changes:

  1. Instead of installing wxWidgets via brew, it installs from the cached copy of wxWidgets. This solves a problem where configure was not finding the WX_CONFIG_CHECK macro.
  2. Explicitly setting the value of -mmacosx-version-min prior to compiling logo. This is a bit belt and suspenders; however, it should prevent a change in the way wxWidgets is managed from impacting the compatibility of the executable build.

Copy link
Owner

@jrincayc jrincayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approve

@jrincayc jrincayc merged commit d810567 into jrincayc:master Jan 17, 2023
@dmalec dmalec deleted the fix-osx-cd-build branch January 18, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants