Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-158: Configure wxWidgets to avoid linking to brew installed libraries #159

Merged
merged 1 commit into from
Feb 19, 2023

Conversation

dmalec
Copy link
Collaborator

@dmalec dmalec commented Feb 19, 2023

Resolves #158

Summary

On the GitHub MacOS runners, it looks like the installation of brew includes libraries which get picked up during the wxWidgets build. This creates a dependency for the UCBLogo binary on the brew installed libraries being present at runtime.

This change configures wxWidgets to use its builtin versions for libpng and libjpeg and configures it to build without libtiff entirely. In my first attempt, I configured libtiff as builtin but that triggered another link to a brew library which doesn't appear to have a builtin option :(

It is possible we can just compile all image libraries as without - willing to try that and see if there are any problems.

Testing

Ran UCBLogo and made sure things that might have image dependencies (such as printing) continued to work as expected.

Test Environments

  • OSX Catalina (10.15.7) on Intel Core i7
  • OSX Ventura (13.2.1) w/ Rosetta on Apple M2

Copy link
Owner

@jrincayc jrincayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look reasonable.

@jrincayc jrincayc merged commit 0737e81 into jrincayc:master Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

M1 Macs: UCBLogo Keeps Crashing
2 participants