Migrate to wxWidgets 3.2 #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For calls to brush(), updated wx_<X> to wxBRUSHSTYLE_<X> * For calls to pen(), updated wx_<X> to wxPENSTYLE_<X>
* CD uses the same wxWidgets for all three build platforms (currently 3.2.2.1) * CD now handles multicore build for Windows wxWidgets * CI verifies using both wxWidgets 3.0 and 3.2
|
I am getting similar results on Ubuntu Jammy w/ wxWidgets 3.0.5 when running the wxWidgets printing sample code. I'm guessing there's something in my set up that's causing grief for some amount of printing / print preview in that configuration. |
jrincayc
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #132
Summary
wxWidgets released 3.2.0 as stable on July 07, 2022. While the 3.0.x line is still being distributed and is also considered stable, this may be a good time to migrate to 3.2.x. As an added plus, the migration for UCBLogo looks like it is relatively straightforward mechanically speaking.
Testing
Tried various functions of the GUI and the interaction with the core Logo interpreter including:
PAUSEandSTOPcommands via the UI to interrupt a running loopNotes
The CI/CD strategy is a bit complicated by where things are today (March 20, 2023):
My proposal on this:
I know this isn't a perfect solution and I am game to rework this for another approach if folks have different ideas on this front.
Test Environments
NOTE: Ubuntu Jammy (22.04) w/ wxWidgets 3.0.5 is an interesting case as I'm seeing some odd behavior when looking at printing / print preview. This appears to be unrelated to the changes in constants as I can get the same behavior with the current
masterbranch code. I'm thinking this might be worth a look independently from the wxWidgets upgrade; but, can also look into it as part of this if that makes more sense.