Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't handle control and alt commands in terminal. #175

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

jrincayc
Copy link
Owner

These need to be handled by wxMenuBar.

Closes #172

These need to be handled by wxMenuBar.
@jrincayc
Copy link
Owner Author

For what it is worth, ChatGPT suggested using event.Skip() and otherwise assisted in this.

@jrincayc
Copy link
Owner Author

jrincayc commented Dec 27, 2023

I am kind of wondering if there are any times when things with Control or Alt are pressed that should be handled by wxTerminal::OnChar
(there is the following code:

    if (event.ControlDown()) keyCode &= 0237;
    if (event.AltDown()) keyCode += 0200;

that is trying to handle those keys.)

@jrincayc
Copy link
Owner Author

Ctrl-M is no-longer gives a return. Ctrl-C and Ctrl-V do copy and paste.

@brianharvey I am trying to decided if I am blocking any input that should still be handled in the text editor with this pull request (Ctrl-M seems to be the only one that this blocks). Thanks

Copy link
Owner Author

@jrincayc jrincayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked.

@jrincayc jrincayc merged commit 2b161b7 into master Jan 11, 2024
2 checks passed
@jrincayc jrincayc deleted the issue_172 branch January 11, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Most mapped keys not working with wxWindows version on Linux Mint
1 participant