Skip to content

Fixing issue of selection of more than 2 cards #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sitegine wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixing issue of selection of more than 2 cards #6

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5291c34
Fixexing issue of selection of more than 2 cards
Apr 13, 2020
5bbf3c8
Fixed - Cards do not seem to be compared/matched correctly
Apr 13, 2020
21e4fff
Fixed - Cards do not seem to be compared/matched correctly.
Apr 13, 2020
18e0b99
Fixed - The game does not end, even after all the cards have been mat…
Apr 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions exercise/scripts/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,30 +14,31 @@ window.addEventListener('DOMContentLoaded', function() {
// collection of selected cards and apply the correct CSS class.
if (selectedCards.length < 2) {
card.classList.add('is-selected');
selectedCards.push(card);
}

// If we have selected two cards, see if they match.
if (selectedCards.length === 2) {
var card1 = selectedCards[0];
var card2 = selectedCards[0];
var card2 = selectedCards[1];

// If the cards match, add them to the collection of matched cards and
// apply the correct CSS class.
if (card1.innerText === card2.innerText) {
matchedCards.push(card1, card2);
matchedCards.push(card1, card2);
card1.classList.add('is-matched');
card2.classList.add('is-matched');
}

// Regardless of whether or not the cards match, deselect them and reset
// the collection of matched cards.
card1.classList.remove('is-selected');
card3.classList.remove('is-selected');
card2.classList.remove('is-selected');
selectedCards = [];
}

// If we've matched all the cards, display a message.
if (matchedCards.length > cards.length) {
if (matchedCards.length >= cards.length) {
alert('You matched all the cards, nice job!');
}
});
Expand Down