Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images are broken on homepage #137

Closed
hadley opened this issue Mar 29, 2022 · 5 comments
Closed

Images are broken on homepage #137

hadley opened this issue Mar 29, 2022 · 5 comments

Comments

@hadley
Copy link
Contributor

hadley commented Mar 29, 2022

https://jrnold.github.io/ggthemes/
@KayleeDavisGitHub KayleeDavisGitHub mentioned this issue Oct 14, 2022
Closed
KayleeDavisGitHub added a commit to KayleeDavisGitHub/ggthemes that referenced this issue Oct 14, 2022
@KayleeDavisGitHub
Add full URL to image directory
0e0c44d 
Adding the full URL should help the site find the images correctly. This change will likely fix Issues jrnold#137 & jrnold#140 (duplicate)
@KayleeDavisGitHub KayleeDavisGitHub mentioned this issue Oct 14, 2022
Merged
@espinielli
Copy link

What worked for me was to have the following fig.path setup in the my README.Rmd

knitr::opts_chunk$set(
  collapse = TRUE,
  comment = "#>",
  fig.path = "man/figures/README-"
)

Probably copied from something I found on the web, like this https://github.com/ThinkR-open/remedy/blob/master/README.Rmd

@KayleeDavisGitHub
Copy link
Contributor

Thanks @espinielli! I sent a pull request yesterday that should fix the README :)
Just waiting on a maintainer to approve that.

@gdickens
Copy link

gdickens commented Sep 9, 2023

Just flagging this issue again. The images are broken at: https://jrnold.github.io/ggthemes/

jrnold pushed a commit that referenced this issue Nov 19, 2023
@KayleeDavisGitHub
Add full URL to image directory (#142)
86410b1 
Adding the full URL should help the site find the images correctly. This change will likely fix Issues #137 & #140 (duplicate)
jrnold added a commit that referenced this issue Feb 8, 2024
@jrnold
Fix broken site links
5bee9e2 
Remove preview section from README.md. These hardcoded links were broken.

Fixes #127, #137, #140.

This is not a long-term solution. A future PR will add autogenerated examples somewhere (#126)
@jrnold jrnold mentioned this issue Feb 8, 2024
Merged
jrnold added a commit that referenced this issue Feb 8, 2024
@jrnold
Fix broken site links (#162)
8ccdfbc 
Remove preview section from README.md. These hardcoded links were broken.

Fixes #127, #137, #140.

This is not a long-term solution. A future PR will add autogenerated examples somewhere (#126)
@jrnold
Copy link
Owner

jrnold commented Feb 8, 2024

Fixed by #162

@jrnold jrnold closed this as completed Feb 8, 2024
@espinielli
Copy link

espinielli commented Feb 9, 2024 •
edited
Loading

Still broken
Screenshot_20240209_080206_Brave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@hadley @jrnold @espinielli @gdickens @KayleeDavisGitHub