Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup + Rust Module Build test #12

Merged
merged 7 commits into from
Feb 4, 2021

Conversation

hypercubestart
Copy link

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.

@hypercubestart
Copy link
Author

hypercubestart commented Jan 6, 2021

I've traced the segfault to this line in the rust code:

let imported_mod = import_python(py, "tvm")?;

It seems like there is a test for this but its ignored

#[ignore]
#[test]
fn test_run() -> Result<()> {
load_python_tvm_(Python::acquire_gil().python()).unwrap();
Ok(())
}

@jroesch jroesch merged commit 44c738b into jroesch:fix-for-therml Feb 4, 2021
@hypercubestart hypercubestart deleted the rust_fix branch February 9, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants