Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized TriangleSplitterBinning #1334

Merged
merged 4 commits into from
Nov 9, 2024
Merged

Optimized TriangleSplitterBinning #1334

merged 4 commits into from
Nov 9, 2024

Commits on Nov 9, 2024

  1. Optimised TriangleSplitterBinning. The main optimisation is to bin in… 

    …to bins on all 3 dimensions, as each triangle is processed.

Not thoroughly tested for correctness.

Results, for a mesh with 152350 tris:

Before optimisations
---------------------
createJoltShapeForBatchedMesh took 0.1297 s, num_allocs: 64, min time so far: 109.7628 ms

With optimisations
-------------------
createJoltShapeForBatchedMesh took 0.0872 s, num_allocs: 64, min time so far: 85.4597 ms
    @Ono-Sendai @jrouwe
    Ono-Sendai authored and jrouwe committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    6915fd9 View commit details
    Browse the repository at this point in the history

  2. Further optimizations + fix possible division by zero

    @jrouwe
    jrouwe committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    cfbd784 View commit details
    Browse the repository at this point in the history

  3. Faster way of getting bounds from triangle

    @jrouwe
    jrouwe committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    bb7093a View commit details
    Browse the repository at this point in the history

  4. Whitespace

    @jrouwe
    jrouwe committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    c63b0c7 View commit details
    Browse the repository at this point in the history