Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added self option to security groups #15

Merged
merged 1 commit into from
Feb 17, 2015

Conversation

lnguyen
Copy link

@lnguyen lnguyen commented Feb 16, 2015

No description provided.

@jrperritt
Copy link
Owner

Hmm, I'm a bit lacking in my security groups knowledge. What is the use case for this? It looks like you're setting the from_group_id to the security group ID if self is set to true. What do we gain by setting from_group_id to the rule's security group instead of leaving from_group_id unset?

@lnguyen
Copy link
Author

lnguyen commented Feb 17, 2015

Use case for this is to assigned a security group to itself. Using openstack_compute_secgroup_v2.name.id doesn't work as resources can't declare itself. This is common practice if we want vms within the security group to be able to access itself. The aws one supports this https://www.terraform.io/docs/providers/aws/r/security_group.html

@jrperritt
Copy link
Owner

Ok, LGTM.

jrperritt added a commit that referenced this pull request Feb 17, 2015
Added self option to security groups
@jrperritt jrperritt merged commit d4cd486 into jrperritt:openstack-gophercloud-v1.0 Feb 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants