Pool a matcher per thread #76
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matching is a leaf operation, so we can pool a matcher per thread to avoid the cost of constructing and initializing the entire matcher for each string. This patch does eliminate all object creation in typical usage, reusing all objects and expecting users to pull match data out of them before using the regex again. However in benchmarks of a regex-heavy StringScanner-based CSV library (jruby/jruby#7604) the overhead of fetching and clearing the pooled matcher appears to hurt performance more than it helps to remove the allocations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching is a leaf operation, so we can pool a matcher per thread to avoid the cost of constructing and initializing the entire matcher for each string.
This patch does eliminate all object creation in typical usage, reusing all objects and expecting users to pull match data out of them before using the regex again. However in benchmarks of a regex-heavy StringScanner-based CSV library (jruby/jruby#7604) the overhead of fetching and clearing the pooled matcher appears to hurt performance more than it helps to remove the allocations.