Skip to content

additional buffer argument #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2018
Merged

additional buffer argument #170

merged 1 commit into from
Oct 17, 2018

Conversation

ahorek
Copy link
Contributor

@ahorek ahorek commented Jul 21, 2018

@ahorek ahorek changed the title WIP: additional buffer argument additional buffer argument Jul 21, 2018
@ahorek ahorek changed the title additional buffer argument WIP: additional buffer argument Jul 21, 2018
@ahorek ahorek force-pushed the buffer branch 2 times, most recently from e978f21 to c1e25e1 Compare July 21, 2018 13:14
@ahorek ahorek changed the title WIP: additional buffer argument additional buffer argument Jul 21, 2018
ahorek
ahorek commented Jul 21, 2018
View reviewed changes
src/test/ruby/test_cipher.rb
buffer = ''
actual = cipher.update('bar' * 10, buffer)
if jruby?
expected = "\xE6\xD3Y\fc\xEE\xBA\xB2*\x0Fr\xD1\xC2b\x03\xD0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a bug?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahorek I just saw this. I don't know. I would expect the two impls to generate the same data.

enebo
enebo reviewed Jul 21, 2018
View reviewed changes
src/main/java/org/jruby/ext/openssl/Cipher.java
}

@JRubyMethod
public IRubyObject update(final ThreadContext context, final IRubyObject arg, IRubyObject buffer) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a @JRubyMethod buffer can be any Ruby type. So you need to do something like TypeConverter.checkStringType.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@kares kares merged commit e13a281 into jruby:master Oct 17, 2018
@janko
Copy link

janko commented Dec 26, 2018 •
edited
Loading

Thanks for the fix! In which JRuby version is this going to be released? I don't see it in JRuby 9.2.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enebo enebo enebo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahorek @janko @enebo @kares