Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core-js implementation #3

Closed
wants to merge 1 commit into from
Closed

Add core-js implementation #3

wants to merge 1 commit into from

Conversation

zloirock
Copy link

No description provided.

@ljharb
Copy link

ljharb commented Dec 17, 2021

It is very irresponsible to publish this as a polyfill; it’s not even stage 2 yet, and the name “unThis” will never achieve consensus.

@zloirock
Copy link
Author

It's unlogical to write it each time when I add a polyfill for an early-stage proposal. Please, avoid it next time. It's only for experimentation and changing name in the future is additional protection from possible problems.

@ljharb
Copy link

ljharb commented Dec 17, 2021

I didn't write it each time; you made similar PRs on two other pre-stage-3 proposals. This one, however, is particularly dangerous, and I think it would be quite harmful to link to it from the proposal's readme.

"Only for experimentation" is irrelevant; modifying builtins in nonstandard ways harms the web, for whatever purpose.

@zloirock
Copy link
Author

zloirock commented Dec 17, 2021

Maybe not each time, but you write it too often. I have more experience in polyfills and web stability than you, so please don't say me what should I do and what I should not do.

"Only for experimentation" is irrelevant

This is an unfounded statement. Without pre-stage 3 polyfills you cant touch the new functionality and check how it works in real life, with other new features. Without it, too many proposals could have the required feedback too late.

harms the web

Some of your cases like this make much more harm for the web than current.

@ljharb
Copy link

ljharb commented Dec 17, 2021

It's not an unfounded statement. Prior to stage 3, all sorts of experimentation can be done without needing to install anything into the environment, and is often done.

The TC39 process doesn't want that feedback until stage 3 - that is what that stage is for.

@zloirock
Copy link
Author

Stage 3 presupposes feedback from JS engine implementors and mass users. As you could see in the process document, polyfills are expected on stage-1 and they help for further advance.

@ljharb
Copy link

ljharb commented Dec 17, 2021

Thanks; I'll update the process document so it no longer incorrectly indicates this about polyfills.

@zloirock

This comment has been minimized.

@ljharb

This comment has been minimized.

@zloirock

This comment has been minimized.

@ljharb

This comment has been minimized.

@js-choi
Copy link
Owner

js-choi commented Dec 17, 2021

Thank you for your work on this, @zloirock. However, in this particular case, I would like to avoid people from using any public polyfills for now, because this proposal is currently very unstable. In particular, its very name, “un-this”, is unstable and likely to change (#1).

We can open this pull request back up once the proposal settles more. Thank you again for your work.

@js-choi js-choi closed this Dec 17, 2021
@js-choi js-choi added the documentation Improvements or additions to documentation label Dec 17, 2021
@zloirock

This comment has been minimized.

@ljharb

This comment has been minimized.

@zloirock
Copy link
Author

@js-choi, since it's only for experiments, instability of the name is not a big problem, however ok, let's wait for stabilization -)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants