Fix dependencies, fix Travis build, fix Integration test #19

tholu · 2019-02-26T15:14:48Z

Grunt removed
Updated all Maven dependencies
Fix Travis build to use current JDKs

…s build

FagnerMartinsBrack

Overall this is good. I've only added a few points to make sure we're not breaking anything for anybody else's dev environment.

Let me know what you think 👍

.gitignore

.travis.yml

package-lock.json

pom.xml

- Updated to a recent version of Wildfly (15.0.1.Final) - Works out-of-the-box with `mvn verify` - All dependencies like node, npm, bower are used as specified in pom.xml - Run `npm install` in js-cookie (installed via bower) to use qunit.js and qunit.css in IT

tholu · 2019-02-27T15:31:24Z

@FagnerMartinsBrack Please do a final review and check, I think it's good to go now.

package.json

src/test/resources/web.xml

FagnerMartinsBrack · 2019-02-28T02:29:53Z

LGTM, just a few leftover questions to understand better the changes

FagnerMartinsBrack · 2019-02-28T02:30:31Z

Let me know when it's ok to land on master

tholu · 2019-02-28T07:01:42Z

@FagnerMartinsBrack Thanks for reviewing, I answered the leftover question and removed the configuration for the missing test. Feel free to merge into master at any time, then I'll continue with the actual bugfixing.

FagnerMartinsBrack · 2019-02-28T08:53:25Z

Oh almost forgot! We need to change the Contributing guidelines since we're not using Grunt anymore!

Can you make the change so that the merge is only one click away? Thanks!

EDIT: Btw I've run the project in your branch and it's all working good, great contribution! I'm speechless.

Waiting for the next :)

FagnerMartinsBrack · 2019-02-28T08:53:54Z

Another quick question, did you figure out how the CookiesEncodingIT.java test file is run by the system? I haven't been touching this project for years!

tholu · 2019-02-28T09:05:00Z

@FagnerMartinsBrack I updated the guidelines accordingly. Maven should now be the only tool needed as a prerequisite.

I had to figure out how it is run to fix it 😁 It took me some time as well, a quick rundown:

Arquillian is used for the Integration Test
Wildfly is used as a Container to deploy the server-side part of the integration test and the test/encoding.html for the client-side part (see next step)
The js-cookie dependency is downloaded via Bower and also brings the test/encoding.html file as well as qunitjs (which is included in test/encoding.html)
qunitjs is a dependency in js-cookie, to get the actual files, npm install needs to be run in the js-cookie folder in bower_components - which is done with the npm, that is installed via Maven
Selenium is used to open test/encoding.html and checks if all tests in the browser succeeded

FagnerMartinsBrack · 2019-02-28T10:49:06Z

I'm getting this error when running mvn verify:

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running com.github.jscookie.javacookie.test.integration.encoding.CookiesEncodingIT
Feb 28, 2019 9:48:31 PM org.jboss.as.arquillian.container.managed.ManagedDeployableContainer startInternal
INFO: Starting container with: [/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/bin/java, -D[Standalone], -Xdebug, -Xrunjdwp:transport=dt_socket,address=8787,server=y,suspend=n, -ea, -Djboss.home.dir=/Users/fagnerbrack/Git/java-cookie/target/wildfly-15.0.1.Final, -Dorg.jboss.boot.log.file=/Users/fagnerbrack/Git/java-cookie/target/wildfly-15.0.1.Final/standalone/log/server.log, -Dlogging.configuration=file:/Users/fagnerbrack/Git/java-cookie/target/wildfly-15.0.1.Final/standalone/configuration/logging.properties, -jar, /Users/fagnerbrack/Git/java-cookie/target/wildfly-15.0.1.Final/jboss-modules.jar, -mp, /Users/fagnerbrack/Git/java-cookie/target/wildfly-15.0.1.Final/modules, org.jboss.as.standalone, -Djboss.home.dir=/Users/fagnerbrack/Git/java-cookie/target/wildfly-15.0.1.Final, -Djboss.server.base.dir=/Users/fagnerbrack/Git/java-cookie/target/wildfly-15.0.1.Final/standalone, -Djboss.server.log.dir=/Users/fagnerbrack/Git/java-cookie/target/wildfly-15.0.1.Final/standalone/log, -Djboss.server.config.dir=/Users/fagnerbrack/Git/java-cookie/target/wildfly-15.0.1.Final/standalone/configuration]
Feb 28, 2019 9:48:31 PM org.jboss.remoting3.EndpointImpl <clinit>
INFO: JBoss Remoting version 5.0.0.Final
Feb 28, 2019 9:48:32 PM org.xnio.Xnio <clinit>
INFO: XNIO version 3.5.1.Final
Feb 28, 2019 9:48:32 PM org.xnio.nio.NioXnio <clinit>
INFO: XNIO NIO Implementation Version 3.5.1.Final
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.xnio.nio.NioXnio$2 (file:/Users/fagnerbrack/.m2/repository/org/jboss/xnio/xnio-nio/3.5.1.Final/xnio-nio-3.5.1.Final.jar) to constructor sun.nio.ch.KQueueSelectorProvider()
WARNING: Please consider reporting this to the maintainers of org.xnio.nio.NioXnio$2
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
Listening for transport dt_socket at address: 8787
org.jboss.modules.ModuleNotFoundException: java.se
	at org.jboss.modules.Module.addPaths(Module.java:1266)
	at org.jboss.modules.Module.link(Module.java:1622)
	at org.jboss.modules.Module.relinkIfNecessary(Module.java:1650)
	at org.jboss.modules.ModuleLoader.loadModule(ModuleLoader.java:296)
	at org.jboss.modules.Main.main(Main.java:437)
Feb 28, 2019 9:48:32 PM org.wildfly.security.Version <clinit>
INFO: ELY00001: WildFly Elytron version 1.1.0.Final
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.794 sec <<< FAILURE!

Results :

Tests in error:
  com.github.jscookie.javacookie.test.integration.encoding.CookiesEncodingIT

Tests run: 1, Failures: 0, Errors: 1, Skipped: 0

[INFO]
[INFO] --- failsafe-maven-plugin:2.4.3-alpha-1:verify (default) @ java-cookie ---
[INFO] Failsafe report directory: /Users/fagnerbrack/Git/java-cookie/target/failsafe-reports
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15.175 s
[INFO] Finished at: 2019-02-28T21:48:34+11:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.codehaus.mojo:failsafe-maven-plugin:2.4.3-alpha-1:verify (default) on project java-cookie: There are test failures.
[ERROR]
[ERROR] Please refer to /Users/fagnerbrack/Git/java-cookie/target/failsafe-reports for the individual test results.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

tholu · 2019-02-28T10:53:00Z

Seems to be related to https://issues.jboss.org/browse/WFLY-10937 (although it should be fixed with WIldfly 15) - I'm still running JDK8 locally, can you try a different JDK as well? I can try to reproduce with JDK11.

FagnerMartinsBrack · 2019-02-28T10:53:01Z

Contents of /Users/fagnerbrack/Git/java-cookie/target/failsafe-reports

org.jboss.arquillian.container.spi.client.container.LifecycleException: The java process starting the managed server exited unexpectedly with code [1]
	at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:152)
	at org.jboss.as.arquillian.container.CommonDeployableContainer.start(CommonDeployableContainer.java:123)
	at org.jboss.arquillian.container.impl.ContainerImpl.start(ContainerImpl.java:179)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:137)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:133)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController.forContainer(ContainerLifecycleController.java:208)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController.startContainer(ContainerLifecycleController.java:133)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86)
	at org.jboss.arquillian.core.impl.EventContextImpl.invokeObservers(EventContextImpl.java:103)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:90)
	at org.jboss.arquillian.container.impl.client.ContainerDeploymentContextHandler.createContainerContext(ContainerDeploymentContextHandler.java:54)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:95)
	at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:133)
	at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:105)
	at org.jboss.arquillian.core.impl.EventImpl.fire(EventImpl.java:62)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$2.perform(ContainerLifecycleController.java:70)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$2.perform(ContainerLifecycleController.java:64)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController.forEachSuiteContainer(ContainerLifecycleController.java:181)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController.startSuiteContainers(ContainerLifecycleController.java:64)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86)
	at org.jboss.arquillian.core.impl.EventContextImpl.invokeObservers(EventContextImpl.java:103)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:90)
	at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:133)
	at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:105)
	at org.jboss.arquillian.core.impl.EventImpl.fire(EventImpl.java:62)
	at org.jboss.arquillian.container.test.impl.client.ContainerEventController.execute(ContainerEventController.java:83)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86)
	at org.jboss.arquillian.core.impl.EventContextImpl.invokeObservers(EventContextImpl.java:103)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:90)
	at org.jboss.arquillian.test.impl.TestContextHandler.createSuiteContext(TestContextHandler.java:69)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:86)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:95)
	at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:133)
	at org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:105)
	at org.jboss.arquillian.test.impl.EventTestRunnerAdaptor.beforeSuite(EventTestRunnerAdaptor.java:71)
	at org.jboss.arquillian.junit.AdaptorManager.initializeAdaptor(AdaptorManager.java:23)
	at org.jboss.arquillian.junit.AdaptorManagerWithNotifier.initializeAdaptor(AdaptorManagerWithNotifier.java:19)
	at org.jboss.arquillian.junit.Arquillian.run(Arquillian.java:109)
	at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
	at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
	at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
	at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
	at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)

FagnerMartinsBrack · 2019-02-28T11:47:16Z

I tried locally and it works in Java 8. Let's just create a bug report for Java 11 and move on.

FagnerMartinsBrack · 2019-02-28T11:49:18Z

X-Ref: #20

Fix dependencies (remove Grunt, update Maven dependencies), fix Travi…

5d79831

…s build

tholu mentioned this pull request Feb 26, 2019

Fix decoding two encoded chars after each other #18

Closed

FagnerMartinsBrack suggested changes Feb 26, 2019

View reviewed changes

.gitignore Show resolved Hide resolved

.travis.yml Show resolved Hide resolved

package-lock.json Show resolved Hide resolved

pom.xml Outdated Show resolved Hide resolved

Thomas Lutz added 3 commits February 27, 2019 16:16

Extend JDK versions to all available on Travis

c16727b

Fix integration tests

5b8bd1a

- Updated to a recent version of Wildfly (15.0.1.Final) - Works out-of-the-box with `mvn verify` - All dependencies like node, npm, bower are used as specified in pom.xml - Run `npm install` in js-cookie (installed via bower) to use qunit.js and qunit.css in IT

JDK6 and JDK7 fail on Travis, require JDK8

8057635

tholu changed the title ~~Fix dependencies, fix Travis build~~ Fix dependencies, fix Travis build, fix Integration test Feb 27, 2019

FagnerMartinsBrack reviewed Feb 28, 2019

View reviewed changes

package.json Show resolved Hide resolved

FagnerMartinsBrack reviewed Feb 28, 2019

View reviewed changes

src/test/resources/web.xml Outdated Show resolved Hide resolved

FagnerMartinsBrack approved these changes Feb 28, 2019

View reviewed changes

Remove configuration for missing test

590619d

Update CONTRIBUTING guidelines, remove grunt, update Tools

5f9fb26

FagnerMartinsBrack merged commit c887dec into js-cookie:master Feb 28, 2019

FagnerMartinsBrack mentioned this pull request Feb 28, 2019

openjdk-11.0.2: org.jboss.modules.ModuleNotFoundException: java.se error using mvn verify #20

Closed

Fix dependencies, fix Travis build, fix Integration test #19

Fix dependencies, fix Travis build, fix Integration test #19

Uh oh!

Conversation

tholu commented Feb 26, 2019

Uh oh!

FagnerMartinsBrack left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tholu commented Feb 27, 2019

Uh oh!

Uh oh!

Uh oh!

FagnerMartinsBrack commented Feb 28, 2019

Uh oh!

FagnerMartinsBrack commented Feb 28, 2019

Uh oh!

tholu commented Feb 28, 2019

Uh oh!

FagnerMartinsBrack commented Feb 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FagnerMartinsBrack commented Feb 28, 2019

Uh oh!

tholu commented Feb 28, 2019

Uh oh!

FagnerMartinsBrack commented Feb 28, 2019

Uh oh!

tholu commented Feb 28, 2019

Uh oh!

FagnerMartinsBrack commented Feb 28, 2019

Uh oh!

FagnerMartinsBrack commented Feb 28, 2019

Uh oh!

FagnerMartinsBrack commented Feb 28, 2019

Uh oh!

Uh oh!

FagnerMartinsBrack commented Feb 28, 2019 •

edited

Loading