Skip to content

Proposal: Adding a baseRef option #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .env.example
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
API_KEY=<web_api_key>
AUTH_DOMAIN=<project_id>.firebaseapp.com
DATABASE_URL=https://<project_id>.firebaseio.com
2 changes: 2 additions & 0 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
1. `clone git@github.com:js-data/js-data-firebase.git`
1. `cd js-data-firebase`
1. `npm install`
1. `cp config.default.js config.js` and enter testing Firebase connection settings
1. `cp .env.example .env` and enter testing Firebase connection settings
1. `npm test` - Lint, build, and test

## To cut a release
Expand Down
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for dis
- [ ] - `npm test` succeeds
- [ ] - Code coverage does not decrease (if any source code was changed)
- [ ] - Appropriate JSDoc comments were updated in source code (if applicable)
- [ ] - Approprate changes to js-data.io docs have been suggested ("Suggest Edits" button)
- [ ] - Appropriate changes to js-data.io docs have been suggested ("Suggest Edits" button)
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ typings/
.vscode
key.json
config.js
.env
.nyc_output/
dist/*.js
dist/*.map
6 changes: 3 additions & 3 deletions config.default.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
window.API_KEY = 'your-api-key';
window.AUTH_DOMAIN = 'your-auth-domain';
window.DATABASE_URL = 'your-database-url';
window.API_KEY = '<web_api_key>';
window.AUTH_DOMAIN = '<project_id>.firebaseapp.com';
window.DATABASE_URL = 'https://<project_id>.firebaseio.com';
1 change: 1 addition & 0 deletions mocha.start.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
var JSData = require('js-data')
var JSDataAdapterTests = require('./node_modules/js-data-adapter/dist/js-data-adapter-tests')
var JSDataFirebase = require('./')
require('dotenv').config()

var firebase = require('firebase')

Expand Down
Loading