stub: add basic binary operators

See #10
js-js · Dec 24, 2014 · 9edf4d4 · 9edf4d4
1 parent fc0ca6f
commit 9edf4d4
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 4 deletions.
diff --git a/lib/js/platform/base/stub.js b/lib/js/platform/base/stub.js
@@ -647,7 +647,7 @@ function binaryStubs() {
     });
   }, this);
 
-  var ops = [ '<', '<=' ];
+  var ops = [ '<', '<=', '>', '>=', '==', '!=' ];
   ops.forEach(function(op) {
     this.declareStub('binary/' + op, function() {/*
       block BinaryLogic -> LeftSmi, LeftNonSmi
@@ -664,6 +664,14 @@ function binaryStubs() {
           smiCompare %"<", left, right
         #elif op === '<='
           smiCompare %"<=", left, right
+        #elif op === '>'
+          smiCompare %"<", right, left
+        #elif op === '>='
+          smiCompare %"<=", right, left
+        #elif op === '=='
+          smiCompare %"==", right, left
+        #elif op === '!='
+          smiCompare %"!=", right, left
         #endif
 
       block True

diff --git a/test/api-test.js b/test/api-test.js
@@ -47,12 +47,32 @@ describe('js.js API', function() {
     it('should do basic binary logic', function() {
       var fn = compile(function() { 1 < 2; });
       assert.equal(fn.call(null, []).cast().value(), true);
-      var fn = compile(function() { 2 < 2; });
+      fn = compile(function() { 2 < 2; });
       assert.equal(fn.call(null, []).cast().value(), false);
-      var fn = compile(function() { 2 <= 2; });
+      fn = compile(function() { 2 <= 2; });
       assert.equal(fn.call(null, []).cast().value(), true);
-      var fn = compile(function() { 3 <= 2; });
+      fn = compile(function() { 3 <= 2; });
       assert.equal(fn.call(null, []).cast().value(), false);
+
+      fn = compile(function() { 1 > 2; });
+      assert.equal(fn.call(null, []).cast().value(), false);
+      fn = compile(function() { 3 > 2; });
+      assert.equal(fn.call(null, []).cast().value(), true);
+      fn = compile(function() { 2 >= 2; });
+      assert.equal(fn.call(null, []).cast().value(), true);
+      fn = compile(function() { 3 >= 2; });
+      assert.equal(fn.call(null, []).cast().value(), true);
+      fn = compile(function() { 1 >= 2; });
+      assert.equal(fn.call(null, []).cast().value(), false);
+
+      fn = compile(function() { 1 == 2; });
+      assert.equal(fn.call(null, []).cast().value(), false);
+      fn = compile(function() { 2 == 2; });
+      assert.equal(fn.call(null, []).cast().value(), true);
+      fn = compile(function() { 2 != 2; });
+      assert.equal(fn.call(null, []).cast().value(), false);
+      fn = compile(function() { 3 != 2; });
+      assert.equal(fn.call(null, []).cast().value(), true);
     });
 
     it('should do string literal', function() {