feat: add error-boundary & error-indicator components #16
Conversation
Aliaksandr-Shliayeu
requested review from
idzeravianka,
vharadkou and
DzianisPasiukou
| @@ -3,10 +3,10 @@ import 'styles/partnersLogo.css'; | |||
|
|
|||
| export const PartnersLogo: React.FC = memo(() => { | |||
| return ( | |||
| <div className="partners-logo"> | |||
There was a problem hiding this comment.
Probably not, but following the "react" best practice, empty tags should be self-closing. Also, I have deleted unnecessary spaces at the end of the string.
| hasError: boolean; | ||
| } | ||
|
|
||
| export default class ErrorBoundry extends React.Component<{}, ErrorBoundryState> { |
There was a problem hiding this comment.
don't use default export.
We don't have code style guide for now and strict rules for that,
but let's do now simple as possible :)
There was a problem hiding this comment.
Removed defaults exports from ErrorBoundry and ErrorIndicator components
| @@ -25,3 +24,5 @@ export default class ErrorBoundry extends React.Component<{}, ErrorBoundryState> | |||
| return this.props.children; | |||
| } | |||
| } | |||
|
|
|||
| export { ErrorBoundry }; | |||
There was a problem hiding this comment.
should be export class ErrorBoundry extends React.Component<{}, ErrorBoundryState> {
| import ErrorBoundry from './error-boundry'; | ||
|
|
||
| export {ErrorBoundry}; | ||
| export {ErrorBoundry} from './error-boundry'; |
There was a problem hiding this comment.
export * from './error-boundry'
| import ErrorIndicator from './error-indicator'; | ||
|
|
||
| export {ErrorIndicator}; | ||
| export { ErrorIndicator } from './error-indicator'; |
vharadkou
changed the title
vharadkou
changed the title
| @@ -0,0 +1,26 @@ | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
typo, rename component to error-boundary
vharadkou
changed the title
Error handler for "hard errors"
##Includes: