Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neutrino.js.org #2021

Merged
merged 1 commit into from
May 23, 2018
Merged

neutrino.js.org #2021

merged 1 commit into from
May 23, 2018

Conversation

edmorley
Copy link
Contributor

Since we're switching from GitHub pages to Netlify, for all the auto-deployment and PR preview goodness.

See:
neutrinojs/neutrino#891

cc @eliperelman

Since we're switching from GitHub pages to Netlify, for all the
auto-deployment and PR preview goodness.

See:
neutrinojs/neutrino#891
@indus indus changed the title Update neutrino.js.org neutrino.js.org May 23, 2018
@indus
Copy link
Member

indus commented May 23, 2018

@eliperelman I took your "Looks great" from neutrinojs/neutrino#891 (review) as an indication that you as the initial requester of the subdomain support the change and processed this change request of @edmorley.

I've made the change in JS.ORGs zonefile but something looks misconfigure (in netlify ?). I get a warning about the SSL certificate. Maybe we should use Cloudflares "Universal SSL" (requires removing ````//noCF``` comment in the PR).

@indus indus added bug organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account change This PR/issue is regarding making a change to an existing subdomain external page This PR has a target of a site that isn't GitHub Pages labels May 23, 2018
@edmorley
Copy link
Contributor Author

@indus thank you for making the change :-)

Netlify has integrated Let's Encrypt support, which I was hoping would kick in automatically - though it appears that they only try to add a custom domain to an existing cert when it's first added to the custom domains list - and not when the DNS is finally updated to match. Removing and re-adding the custom domain entry triggered the cert issuance - https://neutrino.js.org/ works for me now. (It seems like there isn't a way to make it zero downtime when using //noCF.)

Thank you for your help!

@edmorley
Copy link
Contributor Author

(In case it helps anyone else in the future)

Ah though https://www.netlify.com/docs/ssl/#troubleshooting says:

  1. If your site is configured to go through another service (ex: using CloudFlare “acceleration and protection”, or similar), you’ll need to disable that routing before trying to provision a certificate in our UI, so Netlify can handle SSL termination.

So it seems it's just a chicken-and-egg situation for which a downtime is always unavoidable.

@indus
Copy link
Member

indus commented May 23, 2018

Welcoem back https://neutrino.js.org

@indus indus merged commit 7322dc4 into js-org:master May 23, 2018
@indus indus removed the bug label May 23, 2018
@edmorley edmorley deleted the neutrino-netlify branch May 23, 2018 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change This PR/issue is regarding making a change to an existing subdomain external page This PR has a target of a site that isn't GitHub Pages organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants