-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-redux.js.org #3782
react-redux.js.org #3782
Conversation
@markerikson are you okay with this change? (#2391) |
Tim's the other Redux maintainer. @timdorr , what issue is this aimed at solving? Also, should we do this for the Redux and RTK docs sites as well? |
Yes, I'd like Netlify to manage SSL for us. I'd also like CloudFlare out of the loop so they don't block anyone (I've seen that happen on React Router's docs numerous times) I'd like to do the same with RTK over the weekend. The added benefit there is it's not possible to change out the primary domain on that project (from RSK) until they manage SSL for us. |
Sure, go for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
I've just changed the settings for the record to not be processed by Cloudflare (so no "Universal SSL") @markerikson Should we accept future requests by @timdorr without notifiying you? I know he is a major contributor, but of course we don't have insight to the internal responsibilities in a project (thats why we usually ask the first requester of a subdomain in case of change request) |
I'm an owner on the reduxjs org. Mark and I are interchangeable. Bus factor and all 😃 |
I'd appreciate a heads-up just to know if changes are being made, but yeah, Tim and I are co-equals and he can do pretty much whatever he wants :) |
Looking to disable Cloudflare on react-redux.js.org so Netlify can handle SSL instead.