Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-redux.js.org #3782

Merged
merged 1 commit into from
Mar 7, 2020
Merged

react-redux.js.org #3782

merged 1 commit into from
Mar 7, 2020

Conversation

timdorr
Copy link
Contributor

@timdorr timdorr commented Mar 6, 2020

Looking to disable Cloudflare on react-redux.js.org so Netlify can handle SSL instead.

@MattIPv4
Copy link
Member

MattIPv4 commented Mar 6, 2020

@markerikson are you okay with this change? (#2391)

@MattIPv4 MattIPv4 added the awaiting response This PR is waiting for a response from the requester label Mar 6, 2020
@markerikson
Copy link
Contributor

Tim's the other Redux maintainer.

@timdorr , what issue is this aimed at solving? Also, should we do this for the Redux and RTK docs sites as well?

@timdorr
Copy link
Contributor Author

timdorr commented Mar 6, 2020

Yes, I'd like Netlify to manage SSL for us. I'd also like CloudFlare out of the loop so they don't block anyone (I've seen that happen on React Router's docs numerous times)

I'd like to do the same with RTK over the weekend. The added benefit there is it's not possible to change out the primary domain on that project (from RSK) until they manage SSL for us.

@markerikson
Copy link
Contributor

Sure, go for it.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@MattIPv4 MattIPv4 added change This PR/issue is regarding making a change to an existing subdomain external page This PR has a target of a site that isn't GitHub Pages and removed awaiting response This PR is waiting for a response from the requester labels Mar 7, 2020
@indus
Copy link
Member

indus commented Mar 7, 2020

I've just changed the settings for the record to not be processed by Cloudflare (so no "Universal SSL")

@markerikson Should we accept future requests by @timdorr without notifiying you? I know he is a major contributor, but of course we don't have insight to the internal responsibilities in a project (thats why we usually ask the first requester of a subdomain in case of change request)

@indus indus merged commit c091e4c into js-org:master Mar 7, 2020
@timdorr
Copy link
Contributor Author

timdorr commented Mar 7, 2020

I'm an owner on the reduxjs org. Mark and I are interchangeable. Bus factor and all 😃

@markerikson
Copy link
Contributor

I'd appreciate a heads-up just to know if changes are being made, but yeah, Tim and I are co-equals and he can do pretty much whatever he wants :)

@MattIPv4 MattIPv4 mentioned this pull request Aug 1, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change This PR/issue is regarding making a change to an existing subdomain external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants