Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solid-file-upload.js.org #9365

Merged
merged 2 commits into from
Nov 10, 2024
Merged

solid-file-upload.js.org #9365

merged 2 commits into from
Nov 10, 2024

Conversation

Swappea
Copy link
Contributor

@Swappea Swappea commented Nov 9, 2024

@Swappea Swappea changed the title Update cnames_active.js solid-file-upload.js.org Nov 9, 2024
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/Swappea/solid-file-upload/tree/main/dev

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels Nov 9, 2024
@indus indus added the awaiting response This PR is waiting for a response from the requester label Nov 10, 2024
@indus
Copy link
Member

indus commented Nov 10, 2024

@Swappea Without a link to the git repo I don't get what the page is about. I've uploaded two files - and now?

@Swappea
Copy link
Contributor Author

Swappea commented Nov 10, 2024

@indus - The documentation is not yet added completely. It only supports an example for now. I will update the GitHub pages to have some basic documentation and get back to you if it's needed for validation.

Apologies.

@indus
Copy link
Member

indus commented Nov 10, 2024

@Swappea I just think the value at the moment is in library you provide and not in the example. So if you could add a link to the code or npm and/or add some documentation it would be easier for me to accept the subdomain request. I can leave this open for a couple of days but try to have "inbox zero" over longer periods.

@Swappea
Copy link
Contributor Author

Swappea commented Nov 10, 2024

@indus - Could you please check now? I am unable to check as it is redirecting it to js.org site, which is not working as subdomain is not yet configured.

I checked locally and I have updated the documentation. Apologies for taking your time.

@indus indus removed the awaiting response This PR is waiting for a response from the requester label Nov 10, 2024
@indus
Copy link
Member

indus commented Nov 10, 2024

👍 Welcome https://solid-file-upload.js.org

@indus indus merged commit d200cb8 into js-org:master Nov 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants