enhance(alert): Add supporting custom styles to ngxsmart #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new playwright.config.ts file for Playwright end-to-end testing configurations. Moreover, it updates various dependencies to the latest version in package.json and updates the lock file accordingly. Jasmine and Karma related dependencies are replaced with Jest and Playwright related ones.
Modified the main ESLint configuration, .eslintrc.json, to refine the ignore patterns and file overrides. A new rules configuration file for ngxsmart project has been added. Several new plugins have been installed, including eslint-config-prettier, eslint-plugin-import, eslint-plugin-jsdoc and eslint-plugin-prefer-arrow, to improve code quality. Changes have been reflected in both package.json and pnpm-lock.yaml.
Added `ts-ignore`, updated an event parameter, and enabled strict mode in the TSConfig. These essential modifications improve code robustness and ensure compliance to TypeScript's strict type-checking for overall better maintainability.
Added a new @input() property 'class' to alert.component in ngxsmart to allow addition of custom classes to the alert component. This would enable developers to apply more specific styles on the component if needed. The usage is updated in the demo HTML file. Also, minor adjustments are made in the alert-demo.component like changing the initially set dismissOnTimeout property to false, probably done for testing the new feature.
❌ Deploy Preview for js-smart-ngxsmart failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.