05-dom-document-loading #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Добавляю преподавателя (@ufocoder) для код-ревью. |
ufocoder
reviewed
Feb 11, 2025
| this.element = this.createElement(this.createTemplate()); | ||
| } | ||
|
|
||
| show(targetElement) { |
There was a problem hiding this comment.
show(targetElement = document.body) { и не нужно ниже условия
ufocoder
reviewed
Feb 11, 2025
|
|
||
| createBodyCellTemplate(dataItem) { | ||
| return this.headerConfig.map(({id, template}) => { | ||
| if (id === 'images') { |
ufocoder
reviewed
Feb 11, 2025
| } | ||
|
|
||
| sort(field, direction) { | ||
| const newData = [...this.data]; |
There was a problem hiding this comment.
В чем необходимость создавать новый массив?
|
Добавляю преподавателя (@ufocoder) для код-ревью. |
|
Решение было обновлено, посмотрим что скажет @ufocoder |
ufocoder
reviewed
Feb 12, 2025
| }).join(' '); | ||
| } | ||
|
|
||
| sort(field, direction) { |
There was a problem hiding this comment.
Достаточно найти тип сортировки по значние field в this.headerConfig
ufocoder
reviewed
Feb 12, 2025
| } | ||
|
|
||
| createListeners() { | ||
| document.body.addEventListener('pointerdown', (e) => this.handleTableHeaderPointerdown(e)); |
There was a problem hiding this comment.
необходимо добавлять и удалять одни и те же обработчики
ufocoder
reviewed
Feb 12, 2025
| document.body.removeEventListener('pointerdown', (e) => this.handleTableHeaderPointerdown(e)); | ||
| } | ||
|
|
||
| handleTableHeaderPointerdown(e) { |
There was a problem hiding this comment.
createListeners() {
document.body.addEventListener('pointerdown', this.handleTableHeaderPointerdown);
}
destroyListeners() {
document.body.removeEventListener('pointerdown', this.handleTableHeaderPointerdown);
}
handleTableHeaderPointerdown = (e) => {
|
Добавляю преподавателя (@ufocoder) для код-ревью. |
ufocoder
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
05-dom-document-loading