Another distro compatibility #64
Conversation
Small but important compatibility modification for blackPanther OS and another distro in the future
| @@ -29,6 +29,8 @@ set -E | |||
| version="4.2.0" | |||
| scriptName=$(basename "$0") | |||
| bashVersion=$(echo "$BASH_VERSION" | cut -d. -f1) | |||
| # Requres for any other distribution, like blackPanther OS | |||
| DISTRO=$(lsb_release -si | awk '{print $1}'| tr [:upper:] [:lower:]) | |||
There was a problem hiding this comment.
Woud rather have a name in camelCase, such as systemDistro
| @@ -29,6 +29,8 @@ set -E | |||
| version="4.2.0" | |||
| scriptName=$(basename "$0") | |||
| bashVersion=$(echo "$BASH_VERSION" | cut -d. -f1) | |||
| # Requres for any other distribution, like blackPanther OS | |||
| DISTRO=$(lsb_release -si | awk '{print $1}'| tr [:upper:] [:lower:]) | |||
There was a problem hiding this comment.
Is there a guarantee lsb_release would be available in any Linux system? I would rather have a graceful handling for when this command is missing, otherwise the console would be polluted.
There was a problem hiding this comment.
Lots of applications and scripts depends on lsb_release command for compatibility issues. So that shouldn't be a problem.
There was a problem hiding this comment.
I bet you're right. However, since one day this tool might be used on MacOS, I'd rather you replace this shell command with
lsb_release -si 2> /dev/null | awk '{print $1}'| tr [:upper:] [:lower:]
|
There is likely good inspiration to have from https://metacpan.org/pod/distribution/Devel-CheckOS/lib/Devel/CheckOS/Families.pod#THE-Linux::Debian-FAMILY and other parts of that codebase |
|
...on the reliability of certain classifications and their various methods of probing, I mean |
Small but important compatibility modification for blackPanther OS and another distro in the future
name: Pull Request
about: 'Contribute to the project'
title: ''
assignees: jsamr