Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container component for Create Date functionality #1

Merged
merged 6 commits into from
Apr 24, 2018
Merged

Container component for Create Date functionality #1

merged 6 commits into from
Apr 24, 2018

Conversation

sayanm-10
Copy link
Collaborator

@sayanm-10 sayanm-10 commented Apr 23, 2018 •
edited by jsaterfiel
Loading

Implemented

  • CSS pre-processor using node-sass-chokidar Reference
  • Create a level of abstraction b/w index.js and all components
  • Consume Bootstrap and jQuery from package instead of CDN
  • A CreateDate container component that will house the map too
  • A nav bar that captures the number of people on the date and the actual day.

Known Issues

  • If you are using VS Code on a Windows machine, you may see an error on the terminal console on saving a SCSS file. Or the process may just quit w/o warning. This is a known issue for VS Code. Reference 1, Reference 2
  • On larger screen sizes > 1240px, the date holder sticks to the count. Gotta fix that!

@jsaterfiel jsaterfiel merged commit cbd1a58 into master Apr 24, 2018
@jsaterfiel jsaterfiel deleted the sayan_create_date branch April 24, 2018 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sayanm-10 @jsaterfiel