Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for different init managers #23

Merged

Conversation

mqqc
Copy link
Contributor

@mqqc mqqc commented Apr 12, 2023

This MR adds support to run OpenRC under different init managers instead of just sysvinit.
It renames openrc-inittab to virtual/openrc-inittab that can be provided by different packages: openrc-inittab is moved to openrc-inittab-sysvinit that provides virtual/openrc-inittab, and openrc-inittab-busybox is added that allows OpenRC to run under BusyBox init.

Finally, it adds a subpackage for OpenRC's very own init manager, openrc-init, and adds support to run OpenRC under it (by setting VIRTUAL-RUNTIME_init_manager = "openrc-init").

I tried to make the changes clear and atomic by splitting them up into separate commits, but please let me know if anything is fuzzy or non-obvious. Thanks!

@mqqc mqqc changed the base branch from master to langdale April 12, 2023 12:51
@jsbronder
Copy link
Owner

Hey, thanks for all the PRs! It'll be a little bit before I get a chance to review them all, but I did have one question up front. Why did you change the target from master to langdale? Langdale's end-of-life is next month. Ignoring that, things are typically merged into the master branch of layers first, then backported as necessary (if there's interest).

I haven't reviewed everything yet, so I don't know if these PRs are backward compatible or not. If they are, no problem with pulling them back to langdale.

@mqqc
Copy link
Contributor Author

mqqc commented Apr 13, 2023

No problem, thanks for responding. I opted to target langdale as that's the release we're currently basing our builds on, and thus it's the one I'm able to test (not all of the dependent layers in our build are compatible with mickledore yet, sadly). As such, it's more of an indication what version of OE these PRs have been developed and tested against. I'm happy with re-targeting master, but sadly not yet able to give them the same full test this way.

@mqqc mqqc force-pushed the feature/multiple-init-manager-support branch 2 times, most recently from adcdcc9 to 8b8eaa3 Compare April 13, 2023 12:50
@mqqc mqqc force-pushed the feature/multiple-init-manager-support branch 4 times, most recently from d12262a to 985ba00 Compare April 13, 2023 23:10
@mqqc
Copy link
Contributor Author

mqqc commented Apr 13, 2023

Done. One other change I did was set the serial consoles in BusyBox's inittab to askfirst (basically respawn with init asking first on the console to press enter to activate it), since I figure that resource-constrained systems that BusyBox init can run on may not appreciate the overhead of always having a getty running if the console is not in use. This is consistent with e.g. OpenWrt.

Copy link
Owner

@jsbronder jsbronder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished reviewing, just a couple of requests and this is good to merge.

@mqqc mqqc force-pushed the feature/multiple-init-manager-support branch from 985ba00 to 5cc82c2 Compare April 17, 2023 10:34
@mqqc
Copy link
Contributor Author

mqqc commented Apr 17, 2023

Thanks for the review, should be all in order now!

@mqqc mqqc force-pushed the feature/multiple-init-manager-support branch from 5cc82c2 to c88127e Compare April 17, 2023 11:09
@mqqc mqqc force-pushed the feature/multiple-init-manager-support branch from c88127e to 80f498b Compare April 17, 2023 11:24
@jsbronder jsbronder merged commit 80f498b into jsbronder:langdale Apr 17, 2023
@jsbronder
Copy link
Owner

Merged to langdale and master. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants