V3 performance suite #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@platypii Please try out the reworked performance suites. Let me know if you have any suggestions. be sure to read the new README |
platypii
approved these changes
Jan 12, 2025
There was a problem hiding this comment.
Looks good. Was able to run the tests locally. Some minor suggested improvements:
- The output is basically a CSV file but missing a header. It would be cool if it printed a header line first so the user understands that the numbers mean, and so it can be easily pulled into excel, etc.
- V2 tests output some debug logging that would mess up a CSV (
Test: intersect(500) (intersect(circle),500)) - V1 has no hull(sphere) tests?
- V2 has no project tests?
Total time:
V1:
real 245m45.278s
user 292m23.467s
sys 3m29.584s
V2:
real 88m27.849s
user 96m11.581s
sys 0m53.254s
V3:
real 151m10.018s
user 157m35.117s
sys 0m49.152s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes move the test suites into separate packages, which are now managed by lerna-lite. This keeps the environments completely separate, allowing the test suites to be executed without conflicts.
New performance suite for V3 was added as well.