S3Boto3Storage: bucket_params not used

[mattayes]

On line 363 of the _get_or_create_bucket() method of S3Boto3Storage, bucket_params is defined and includes the bucket's ACL setting. However, when bucket.create() is called, bucket_params isn't used and ACL is set explicitly.

Additionally, if a region is specified, it's added to bucket_params but not set when bucket.create() is called. This makes all created buckets default to us-standard.

Here's the offending lines:

bucket_params = {'ACL': self.bucket_acl}
region_name = self.connection.meta.client.meta.region_name
if region_name != 'us-east-1':
    bucket_params['CreateBucketConfiguration'] = {'LocationConstraint': region_name}
bucket.create(ACL=self.bucket_acl)

I believe the bucket.create() call should be bucket.create(**bucket_params). I'll submit a PR for this in the next five minutes or so.

[jschneier]

Yep.

[jschneier]

Added a test. Thanks.