Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more input validation to dropbox.py #1020

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Add more input validation to dropbox.py #1020

merged 1 commit into from
Sep 9, 2021

Conversation

makspll
Copy link
Contributor

@makspll makspll commented Jun 7, 2021

Proposed additional input validation from settings.py otherwise wrong values produce cryptic error:

File "/app/.heroku/python/lib/python3.7/site-packages/stone/backends/python_rsrc/stone_base.py", line 141, in __init__
     assert validator is not None, 'Invalid tag %r.' % tag
 AssertionError: Invalid tag True.

found and explained here: https://stackoverflow.com/questions/67872466/error-when-uploading-viewing-certain-pictures-rendition-not-found-django-sto

@jschneier
Copy link
Owner

@makspll this can more clearly be written as if write_mode not in ["add", "overwrite", "update"]. The idea is solid though. Mind rebasing and making that change?

Proposed additional input validation from settings.py otherwise wrong values produce cryptic error:
```
File "/app/.heroku/python/lib/python3.7/site-packages/stone/backends/python_rsrc/stone_base.py", line 141, in __init__
     assert validator is not None, 'Invalid tag %r.' % tag
 AssertionError: Invalid tag True.
```

found and explained here: https://stackoverflow.com/questions/67872466/error-when-uploading-viewing-certain-pictures-rendition-not-found-django-sto
@makspll
Copy link
Contributor Author

makspll commented Sep 9, 2021

@jschneier i believe that's the branch rebased and squashed now!

@jschneier jschneier merged commit 77874d7 into jschneier:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants