Fix memory leak, close SpooledTemporaryFile #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. How did you discover the leak (I want to see if I can write a test). Also, the same code (basically) exists on line 174 + 175 and I'm not able to puzzle out why it's there, any thoughts on that? |
|
We just run out of memory when getting files over OurModel.objects.filter(...) Django queryset caches all model instances, thats means even with restriction I didn't remove lines 174 + 175 b/c |
|
Okay. I'll remove those lines after this, I don't think they make any sense. Thanks for the patch. |
jschneier
added a commit
that referenced
this pull request
Jan 19, 2016
Fix memory leak, close SpooledTemporaryFile
jschneier
added a commit
that referenced
this pull request
Jan 19, 2016
This was referenced Jul 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.