-
-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3Boto3Storage: Fix _get_or_create_bucket #196
Conversation
Current coverage is 59.32% (diff: 0.00%)@@ master #196 diff @@
==========================================
Files 17 17
Lines 1693 1694 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1005 1005
- Misses 688 689 +1
Partials 0 0
|
Hi and thanks for the PR! My one point of concern is that we are now calling |
ca6d23a
to
6e85bca
Compare
@jschneier I updated the PR to address your concerns. Are head requests actually charged for? I couldn't find them on the pricing page: https://aws.amazon.com/s3/pricing/ |
I assume that it's contained within this:
|
Thanks, merged |
The current implementation throws an
ImproperlyConfigured
error instead of creating the bucket. This occurs even whenAWS_AUTO_CREATE_BUCKET
has been set to true.