Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3Boto3Storage: Fix _get_or_create_bucket #196

Merged
merged 1 commit into from
Jan 12, 2017

Conversation

linuxlewis
Copy link
Contributor

The current implementation throws an ImproperlyConfigured error instead of creating the bucket. This occurs even when AWS_AUTO_CREATE_BUCKET has been set to true.

@codecov-io
Copy link

codecov-io commented Aug 31, 2016

Current coverage is 59.32% (diff: 0.00%)

Merging #196 into master will decrease coverage by 0.03%

@@             master       #196   diff @@
==========================================
  Files            17         17          
  Lines          1693       1694     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1005       1005          
- Misses          688        689     +1   
  Partials          0          0          

Powered by Codecov. Last update 9bd76bc...3b22fde

@jschneier
Copy link
Owner

Hi and thanks for the PR! My one point of concern is that we are now calling .head_bucket unconditionally which would add more calls (that people pay for!). Do you have any thoughts on that?

@linuxlewis
Copy link
Contributor Author

@jschneier I updated the PR to address your concerns. Are head requests actually charged for? I couldn't find them on the pricing page: https://aws.amazon.com/s3/pricing/

@jschneier
Copy link
Owner

jschneier commented Jan 12, 2017

I assume that it's contained within this:

GET and all other Requests $0.004 per 10,000 requests

@jschneier jschneier merged commit 630825b into jschneier:master Jan 12, 2017
@jschneier
Copy link
Owner

Thanks, merged

jschneier added a commit that referenced this pull request Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants