Fix safe_join to handle trailing slash with intermediate paths #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
==========================================
+ Coverage 75.61% 75.63% +0.01%
==========================================
Files 11 11
Lines 1542 1547 +5
==========================================
+ Hits 1166 1170 +4
- Misses 376 377 +1
Continue to review full report at Codecov.
|
|
This project has been critically under-tested since I obtained, part of the reason I am hesitant to release so it's not that big of a surprise. Thanks for the vigilance. |
|
@jschneier don't be hesitant to make fast releases! IMHO it'll only get more testing if the pypi tip is kept close to master. |
|
I released 1.6.2 with this fix. |
|
@jleclanche yeah, a good point. |
This was referenced Jun 22, 2017
This was referenced Jun 23, 2017
This was referenced Jun 26, 2017
This was referenced Jul 27, 2017
This was referenced Nov 10, 2017
|
please someone help #608 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression introduced in 895a068
Partially reverts 39a2a7a
@jschneier Apologies for the 2nd round of regression fixes. I believe I've covered all edge cases with this fix. I have added many more unit tests and more thoroughly tested against my own projects. All feedback welcome. If the diff looks good, I'd appreciate if a new release could get cut as my previous changes to
safe_join()is broken. Thanks!