Update S3Boto3Storage class by updating size method to read the file …

[mabuaisha]

Update size method of S3Boto3Storage to read size using size and not content_lenght

[codecov-io]

Codecov Report

Merging #366 into master will not change coverage.
The diff coverage is 50%.

@@           Coverage Diff           @@
##           master     #366   +/-   ##
=======================================
  Coverage   75.61%   75.61%           
=======================================
  Files          11       11           
  Lines        1546     1546           
=======================================
  Hits         1169     1169           
  Misses        377      377

Impacted Files	Coverage Δ
storages/backends/s3boto3.py	85.71% <0%> (ø)	⬆️
storages/__init__.py	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e88dd98...5e250ce. Read the comment docs.

[mabuaisha]

@jschneier I add a fix for getting size of file when using boto3 and I need that fix so that django-storage and boto3 can working

[jschneier]

Merged in 4501f99. Version bump will come soon, please use master until then. Thanks for the report and patch.

[mabuaisha]

@jschneier Thanks for merging this to master

[mabuaisha]

@jschneier It seems the commit fix did not fix the issue because the following method

    def size(self, name):
        name = self._normalize_name(self._clean_name(name))
        if self.entries:
            entry = self.entries.get(name)
            if entry:
                return entry.size
            return 0
        return self.bucket.Object(self._encode_name(name)).content_length

entry instance could be a type of the following s3.Object which need to read from content_length or it could be an instance type of s3.ObjectSummary which need to read from size

So to solve the above issue I think we need to check the instance type before reading from size

if isinstance(entry, s3.Object):
    return entry.content_length

elif isinstance(entry, s3.ObjectSummary)
      return entry.size

Please let me know what do you think ?

[jschneier]

I'm wondering if this is a bug in boto3 that might depend on your version. What version of boto3 are you using?

[jschneier]

Nevermind, it appears to be intentional. We can use a hasattr check.

[jschneier]

Pushed 523ab59.

[mabuaisha]

@jschneier Thanks for your released to handle that :)