Fix ValueError crash in S3Boto3Storage #437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like some tests require updates; looking into it. |
|
Tests are failing for python 3.3, see #438 for a fix. |
xrmx
reviewed
Dec 10, 2017
| @@ -446,8 +446,7 @@ def _save(self, name, content): | |||
| # even if wrapped file-like object exists. To avoid Django-specific | |||
| # logic, pass internal file-like object if `content` is `File` | |||
| # class instance. | |||
| if isinstance(content, File): | |||
| content = content.file | |||
| content.name = name | |||
|
Merged #754 to fix this instead, thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this storage with
ManifestFilesMixin, and in some othernot-so-uncommon scenarios.
This tweak essentially retains the changes from c73680e, but fixes #382.