S3 large multipart uploads #450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tveastman, see also @jeffcjohnson's PR here: https://github.com/jschneier/django-storages/pull/400/files in response to #383 @jschneier, are there any plans to merge one of these pull requests soon, replacing |
gomlgs
added a commit
to gomlgs/django-storages
that referenced
this pull request
Mar 20, 2018
gomlgs
added a commit
to gomlgs/django-storages
that referenced
this pull request
Mar 20, 2018
… this makes tests happier and works just as well.
gomlgs
added a commit
to gomlgs/django-storages
that referenced
this pull request
Mar 20, 2018
gomlgs
added a commit
to gomlgs/django-storages
that referenced
this pull request
Mar 20, 2018
… this makes tests happier and works just as well.
gomlgs
added a commit
to gomlgs/django-storages
that referenced
this pull request
Mar 20, 2018
gomlgs
added a commit
to gomlgs/django-storages
that referenced
this pull request
Mar 20, 2018
… this makes tests happier and works just as well.
|
Going to merge this in #548. Thanks everyone for the help and the patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the multipart-upload bug described in #449, the download
.read()issue described in #383, and adds a safeguard to prevent opening the file inrwmode, which at the moment would lead to corruption of the object in S3.