Reset file read offset before passing it to GoogleCloudStorage #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manufont
changed the title
Codecov Report
@@ Coverage Diff @@
## master #481 +/- ##
==========================================
- Coverage 77.1% 76.12% -0.99%
==========================================
Files 10 11 +1
Lines 1520 1579 +59
==========================================
+ Hits 1172 1202 +30
- Misses 348 377 +29
Continue to review full report at Codecov.
|
manufont
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django's default FileSystemStorage uses File.chunks methods, that calls
file.seek(0)on every file read.Google cloud storage, however, uses file.read() (as seen here), which doesn't reset read offset.
This PR force read offset when passing the file to google cloud storage library, thus reducing the difference between these 2 storage implementations.