Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken azure=dependencies #791

Closed
wants to merge 6 commits into from
Closed

Fix broken azure=dependencies #791

wants to merge 6 commits into from

Conversation

sebgrebe
Copy link

@sebgrebe sebgrebe commented Nov 17, 2019 •
edited
Loading

Current problem: During build of eahub.org, this error occurs:

    from azure.common import AzureMissingResourceHttpError
ModuleNotFoundError: No module named 'azure.common'```

This is a problem within django-storages: Azure.common is required, but not listed in django-storages' requirements, as documented [here](https://github.com/jschneier/django-storages/issues/787). I fixed this by adding it to the requirements. 

Once I fixed this, another issue occured, as documented [here](https://github.com/jschneier/django-storages/issues/784). I fixed it by pinning the dependency to an earlier release.

Hopefully, django-storages will fix these issues and we can then fork the latest release.

nitely and others added 6 commits March 1, 2019 13:09
@nitely
support all blobstorage settings
f7fba22
@taymonbeal
Merge remote-tracking branch 'satellogic/nitely_azure_blob'
9e339de 
This incorporates the changes from #658, most relevantly (for our purposes) support for AZURE_CONNECTION_STRING.
@taymonbeal
Pass permissions by keyword
d52ba5d 
For compatibility with azure-blob-storage 2.0.

Fixes #704.

Tests to follow.
@taymonbeal
Merge branch 'azure-2.0-fix-704'
210e870 
Getting tests working on this proved difficult, and I need to get it into production now.
@taymonbeal
Merge remote-tracking branch 'upstream/master'
7f15f8a
@sebbeckercode
fix broken azure dependencies
2eaf0c2
@sebgrebe sebgrebe closed this Nov 17, 2019
@sebgrebe sebgrebe deleted the fix-broken-azure=dependencies branch November 17, 2019 21:34
@sebgrebe sebgrebe restored the fix-broken-azure=dependencies branch November 17, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebgrebe @nitely @taymonbeal @sebbeckercode