Added utf-8 support for ftp storage #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see, the default is |
|
Yes. Only in the form of setting in the settings.py file, please. Thanks. I opened the opportunity to fix |
|
Please update the PR with the setting. |
jschneier
reviewed
Feb 7, 2020
storages/backends/ftp.py
Outdated
| location = location or setting('FTP_STORAGE_LOCATION') | ||
| if location is None: | ||
| raise ImproperlyConfigured("You must set a location at " | ||
| "instanciation or at " | ||
| " settings.FTP_STORAGE_LOCATION'.") | ||
| self.location = location | ||
| self.encoding = encoding or settings('FTP_STORAGE_ENCODING') or 'latin-1' |
There was a problem hiding this comment.
This should be setting( instead of settings(.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add utf-8 support for ftp storage .