Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: guard for length check #18

Merged
merged 1 commit into from
Nov 24, 2023
Merged

fix: guard for length check #18

merged 1 commit into from
Nov 24, 2023

Conversation

jscottsmith
Copy link
Owner

Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
parallax-controller ❌ Failed (Inspect) Nov 24, 2023 5:55pm

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b9ea98e) 85.52% compared to head (b52b46e) 85.52%.

Files Patch % Lines
src/classes/ParallaxController.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   85.52%   85.52%           
=======================================
  Files          28       28           
  Lines         739      739           
  Branches      151      151           
=======================================
  Hits          632      632           
  Misses        107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

size-limit report 📦

Path Size
dist/parallax-controller.cjs.production.min.js 5.75 KB (+0.35% 🔺)
dist/parallax-controller.esm.js 5.88 KB (+0.42% 🔺)

@jscottsmith jscottsmith merged commit 37e19a1 into master Nov 24, 2023
4 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants