Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor getExpandedStyle.ts #209

Merged

Conversation

HiteshGorana
Copy link
Contributor

  • using the chaining operator instead of the ternary operator
  • added type annotation in getExpandedStyle
  • duplicated calculation javascript Math.abs(speed) * 10 * -1 into a variable

@vercel
Copy link

vercel bot commented Apr 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-scroll-parallax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2023 6:57am

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 🎉

Comparison is base (2ff50ca) 85.65% compared to head (437df08) 85.71%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
+ Coverage   85.65%   85.71%   +0.06%     
==========================================
  Files          19       19              
  Lines         237      238       +1     
  Branches       51       51              
==========================================
+ Hits          203      204       +1     
  Misses         33       33              
  Partials        1        1              
Impacted Files Coverage Δ
...ponents/ParallaxBanner/helpers/getExpandedStyle.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jscottsmith jscottsmith merged commit cc95a1b into jscottsmith:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants