This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
Misc: do not modify CST in check mode #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Slightly changes token-assert API by providing result of the check with return values * Apply fixes only in fix mode * Modify couple rules to adjust to new strategy * Make "fixed" property of the Error instance consistent * Introduce "fix" property of the Error class * Divide fix behaviour on "common" and "specific" actions Consequently should speed up linting Fixes jscs-dev#2250
I think we can live with that in maintenance mode |
markelog
added a commit
that referenced
this pull request
May 18, 2016
* Slightly changes token-assert API by providing result of the check with return values * Apply fixes only in fix mode * Modify couple rules to adjust to new strategy * Make "fixed" property of the Error instance consistent * Introduce "fix" property of the Error class * Divide fix behaviour on "common" and "specific" actions Consequently should speed up linting Fixes #2244
This was referenced May 27, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with return values
Consequently should speed up linting
Fixes #2250
/cc @mdevils