feat(swc-plugin-angular): ✨ optional transform styleUrl and styleUrls #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edbzn
approved these changes
Oct 13, 2024
edbzn
force-pushed
the
swc-plugin-styleurls
branch
2 times, most recently
from
fb1e1ed to
35eddf8
Compare
This adds replacing `styleUrls` with actual style imports instead of empty `styles: []`. Useful when generating code for browser such as Webpack/Vite dev server.
This disables importing styles and keeps the old behavior that replaces `styleUrls` with empty `styles: []` by default. Some tests don't import CSS as strings, for example Jest imports them as objects, which breaks Angular. You need to change Jest config to fix this. To avoid making this a breaking change and force users to change existing config, style importing is disabled by default.
edbzn
force-pushed
the
swc-plugin-styleurls
branch
from
35eddf8 to
e1f40d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new option
importStylestoswc-plugin-angular, enabling replacingstyleUrlandstyleUrlswith actual CSS file imports instead of emptystyles: [].Useful when generating code for browser such as Webpack/Vite dev server.
Disabled by default because some tests don't import CSS as strings by default, which can break Angular component creation.
Closes #410.