feat: add support for Nx 20

jscutlery · Dec 3, 2024 · d73cf9d · d73cf9d
1 parent 521ea8c
commit d73cf9d
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 9 deletions.
diff --git a/packages/semver/package.json b/packages/semver/package.json
@@ -13,7 +13,7 @@
     "url": "https://github.com/jscutlery/semver"
   },
   "peerDependencies": {
-    "@nx/devkit": "^18.0.0 || ^19.0.0"
+    "@nx/devkit": "^18.0.0 || ^19.0.0 || ^20.0.0"
   },
   "dependencies": {
     "chalk": "4.1.2",

diff --git a/packages/semver/src/executors/version/__snapshots__/index.e2e.spec.ts.snap b/packages/semver/src/executors/version/__snapshots__/index.e2e.spec.ts.snap
@@ -3,13 +3,11 @@
 exports[`@jscutlery/semver @jscutlery/semver:migrate-nx-release should generate CHANGELOG.md: b-0.3.0 1`] = `
 "## 0.3.0 (yyyy-mm-dd)
 
-
 ### 🚀 Features
 
 - **b:** 🚀 new feature
 
-
-### ❤️  Thank You
+### ❤️ Thank You
 
 - Test Bot
 

diff --git a/packages/semver/src/executors/version/testing.ts b/packages/semver/src/executors/version/testing.ts
@@ -108,9 +108,9 @@ export function setupTestingWorkspace(): TestingWorkspace {
     },
 
     generateLib(name: string, options = '') {
-      const commonArgs = `--unitTestRunner=none --linter=none --bundler=none --minimal --skipFormat --projectNameAndRootFormat=as-provided`;
+      const commonArgs = `--unitTestRunner=none --linter=none --bundler=tsc --minimal --skipFormat`;
       this.runNx(
-        `g @nx/js:lib ${name} --directory=libs/${name} ${commonArgs} ${options}`,
+        `g @nx/js:lib --directory=libs/${name} ${commonArgs} ${options}`,
       );
     },
 
@@ -167,6 +167,7 @@ export function createFakeContext({
       nodes: {},
       dependencies: {},
     },
+    nxJsonConfiguration: {},
   } satisfies ExecutorContext;
 }
 

diff --git a/packages/semver/src/executors/version/utils/post-target.ts b/packages/semver/src/executors/version/utils/post-target.ts
@@ -23,9 +23,8 @@ export function runPostTargets({
   return concat(
     ...postTargets.map((postTargetSchema) =>
       defer(async () => {
-        // TODO: deprecate specifying the project name in the post target schema.
         const target = postTargetSchema.includes(':')
-          ? parseTargetString(postTargetSchema)
+          ? parseTargetString(postTargetSchema, context.projectGraph)
           : parseTargetString(postTargetSchema, context);
 
         _checkTargetExist(target, context);

diff --git a/yarn.lock b/yarn.lock
@@ -2115,7 +2115,7 @@ __metadata:
     inquirer: "npm:8.2.6"
     rxjs: "npm:7.8.1"
   peerDependencies:
-    "@nx/devkit": ^18.0.0 || ^19.0.0
+    "@nx/devkit": ^18.0.0 || ^19.0.0 || ^20.0.0
   languageName: unknown
   linkType: soft