Go back to the deprecated url.parse
#1391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
develop-xmr-url
branch
from
df0216d to
5311fd1
Compare
XhmikosR
force-pushed
the
develop-xmr-url
branch
from
5311fd1 to
4afa757
Compare
XhmikosR
force-pushed
the
develop-xmr-url
branch
from
4afa757 to
db3a360
Compare
This was referenced Nov 6, 2019
XhmikosR
force-pushed
the
develop-xmr-url
branch
from
3edfd3c to
0c287a6
Compare
XhmikosR
force-pushed
the
develop-xmr-url
branch
2 times, most recently
from
25f05b8 to
4b91fc8
Compare
While deprecated, it's much cleaner to use this when we have relative URLs. It also appears to be a lot faster.
XhmikosR
force-pushed
the
develop-xmr-url
branch
from
4b91fc8 to
88cb95e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While deprecated, it's much cleaner to use this when we have relative URLs. It also appears to be a lot faster.
Also, there's an open issue about this in Node.js nodejs/node#12682