fix: measurement results behaviour (#23)

* ref: ping: report failed cmd

* ref: trace: report failed cmd

* ref: dns: return empty obj on missing answer

* ref: dns result schema

* fix: traceroute: missing trim

* fix: return empty string on missing error.stderr

@types/node-dig-dns.d.ts

@@ -9,6 +9,8 @@ declare module 'node-dig-dns' {
 
 	export type DnsQueryResult = {
 		answer: SingleDnsQueryResult[];
+		time: number;
+		server: string;
 	};
 
 	export function dig(args: string[]): Promise<DnsQueryResult>;

src/command/dns-command.ts

@@ -62,7 +62,11 @@ export class DnsCommand implements CommandInterface<DnsOptions> {
 		socket.emit('probe:measurement:result', {
 			testId,
 			measurementId,
-			result: result.answer,
+			result: {
+				answer: result.answer || [],
+				time: result.time,
+				server: result.server,
+			},
 		});
 	}
 }

src/command/ping-command.ts

@@ -1,6 +1,6 @@
 import Joi from 'joi';
 import type {Socket} from 'socket.io-client';
-import {execa, ExecaChildProcess} from 'execa';
+import {execa, ExecaChildProcess, ExecaError} from 'execa';
 import type {CommandInterface} from '../types.js';
 import {InvalidOptionsException} from './exception/invalid-options-exception.js';
 
@@ -47,12 +47,21 @@ export class PingCommand implements CommandInterface<PingOptions> {
 			});
 		});
 
-		const result = await cmd;
+		let result = {};
+
+		try {
+			const cmdResult = await cmd;
+			result = this.parse(cmdResult.stdout);
+		} catch (error: unknown) {
+			result = {
+				rawOutput: (error as ExecaError).stderr?.toString() ?? '',
+			};
+		}
 
 		socket.emit('probe:measurement:result', {
 			testId,
 			measurementId,
-			result: this.parse(result.stdout),
+			result,
 		});
 	}
 

src/command/traceroute-command.ts

@@ -1,6 +1,6 @@
 import Joi from 'joi';
 import type {Socket} from 'socket.io-client';
-import {execa, ExecaChildProcess} from 'execa';
+import {execa, ExecaChildProcess, ExecaError} from 'execa';
 import type {CommandInterface} from '../types.js';
 import {InvalidOptionsException} from './exception/invalid-options-exception.js';
 
@@ -69,12 +69,20 @@ export class TracerouteCommand implements CommandInterface<TraceOptions> {
 			});
 		});
 
-		const result = await cmd;
+		let result = {};
+		try {
+			const cmdResult = await cmd;
+			result = this.parse(cmdResult.stdout.trim());
+		} catch (error: unknown) {
+			result = {
+				rawOutput: (error as ExecaError).stderr?.toString() ?? '',
+			};
+		}
 
 		socket.emit('probe:measurement:result', {
 			testId,
 			measurementId,
-			result: this.parse(result.stdout.trim()),
+			result,
 		});
 	}