fix: ip targets break private ip check (#63)

jsdelivr · Jun 22, 2022 · 652eedc · 652eedc
1 parent 9130a8e
commit 652eedc
Show file tree

Hide file tree

Showing 3 changed files with 62 additions and 9 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -10,6 +10,7 @@
     "crypto-random-string": "^5.0.0",
     "execa": "^6.1.0",
     "got": "^12.0.3",
+    "is-ip": "^4.0.0",
     "joi": "^17.6.0",
     "lodash": "^4.17.21",
     "physical-cpu-count": "^2.0.0",

diff --git a/src/command/mtr-command.ts b/src/command/mtr-command.ts
@@ -1,4 +1,5 @@
 import dns from 'node:dns';
+import {isIP} from 'is-ip';
 import isIpPrivate from 'private-ip';
 import Joi from 'joi';
 import type {Socket} from 'socket.io-client';
@@ -189,6 +190,14 @@ export class MtrCommand implements CommandInterface<MtrOptions> {
 	}
 
 	private async checkForPrivateDest(target: string): Promise<void> {
+		if (isIP(target)) {
+			if (isIpPrivate(target)) {
+				throw new Error('private destination');
+			}
+
+			return;
+		}
+
 		const [ipAddress] = await this.dnsResolver(target);
 
 		if (isIpPrivate(String(ipAddress))) {