Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: unified WS error handler #49

Merged
merged 16 commits into from
Mar 29, 2022
Merged

feat: unified WS error handler #49

merged 16 commits into from
Mar 29, 2022

Conversation

patrykcieszkowski
Copy link
Contributor

@patrykcieszkowski patrykcieszkowski commented Mar 24, 2022 •
edited
Loading

resolve #43
jsdelivr/globalping-probe#13

changes:

  • adds WSError instance
  • adds error handler
  • api:error event
  • api:connect:location event
  • refactors helper/probe-ip-limit.ts
  • refactors middleware/probe-metadata.ts
  • refactors connect event

@jimaek jimaek temporarily deployed to jsdelivr-glo-43-ws-erro-bhgy05 March 24, 2022 11:18 Inactive
@jimaek jimaek temporarily deployed to jsdelivr-glo-43-ws-erro-bhgy05 March 24, 2022 12:01 Inactive
@patrykcieszkowski patrykcieszkowski mentioned this pull request Mar 24, 2022
Merged
zarianec
zarianec suggested changes Mar 24, 2022
View reviewed changes
src/lib/ws/middleware/probe-metadata.ts Outdated Show resolved Hide resolved
src/lib/ws/middleware/index.ts Outdated Show resolved Hide resolved
src/lib/ws/helper/probe-ip-limit.ts Outdated Show resolved Hide resolved
src/lib/ws/helper/error-handler.ts Outdated Show resolved Hide resolved
@jimaek jimaek temporarily deployed to jsdelivr-glo-43-ws-erro-bhgy05 March 25, 2022 08:14 Inactive
zarianec
zarianec reviewed Mar 25, 2022
View reviewed changes
src/lib/internal-error.ts Outdated Show resolved Hide resolved
@zarianec
Copy link
Contributor

And add tests please, at least for errorHandler.

@jimaek jimaek temporarily deployed to jsdelivr-glo-43-ws-erro-bhgy05 March 25, 2022 11:13 Inactive
@jimaek jimaek temporarily deployed to jsdelivr-glo-43-ws-erro-bhgy05 March 28, 2022 08:34 Inactive
@jimaek jimaek temporarily deployed to jsdelivr-glo-43-ws-erro-bhgy05 March 28, 2022 11:02 Inactive
@zarianec zarianec merged commit e2002be into master Mar 29, 2022
@zarianec zarianec deleted the 43-ws-error-handling branch March 29, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zarianec zarianec zarianec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forward error messages to the probe client
3 participants
@patrykcieszkowski @zarianec @jimaek