Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GP: switching test type with map off #663

Merged
merged 7 commits into from
Aug 13, 2024
Merged

GP: switching test type with map off #663

merged 7 commits into from
Aug 13, 2024

Conversation

xbpcb
Copy link
Collaborator

@xbpcb xbpcb commented Aug 8, 2024

Fix #662

@xbpcb xbpcb self-assigned this Aug 8, 2024
Copy link

render bot commented Aug 8, 2024

@MartinKolarik
Copy link
Member

This doesn't look very good in the end :( Is there a reason why we hide the results after changing the test type? Editing other fields doesn't do anything with the results until the user hits Run. Maybe we can just keep the results there and not mess with the map.

@MartinKolarik MartinKolarik merged commit 5fe4064 into master Aug 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GP: switching test type with map off
2 participants