Preliminary support for callback interfaces #182
Merged
+315
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented JS-to-IDL type conversion but not: - Saving callback context [1] - Call a user object's operation [2] - IDL-to-JS type conversion (jsdom#71) - Legacy callback interface object [3] Helps fix jsdom/jsdom#2869. [1]: https://heycam.github.io/webidl/#dfn-callback-context [2]: https://heycam.github.io/webidl/#call-a-user-objects-operation [3]: https://heycam.github.io/webidl/#dfn-legacy-callback-interface-object
ExE-Boss
approved these changes
Mar 26, 2020
domenic
approved these changes
Mar 26, 2020
| } else { | ||
| if (!utils.isObject(curArg)) { | ||
| throw new TypeError( | ||
| \\"Failed to execute 'addEventListener' on 'EventTarget': parameter 2\\" + \\" is not an object\\" |
There was a problem hiding this comment.
I think you could make this all one string by tweaking the source.
There was a problem hiding this comment.
I'd like to punt on this. This is slightly difficult, considering I'm currently doing
`${errPrefix} + " is not an object"`and errPrefix can really be anything, string literal or not. This is also not the only place in the snapshot that has something like this.
Yes. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented JS-to-IDL type conversion but not:
Those things are left to more ambitious pull requests in the future.
Fixes jsdom/jsdom#2869.
I've tested this by linking webidl2js in jsdom (also jsdom/jsdom#2919) and it does fix jsdom/jsdom#2869. Some things in this PR are gathered from elsewhere (like my own #123). But others, like union extraction and type distinguishability bits, were written anew, as they are not handled correctly by any of the other open PRs on callback interfaces (#123, #172, #178). This PR should complement with them nicely.