Tweak test cases for dictionary defaults #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Web IDL these days, optional dictionary arguments must have a trailing "= {}". This adds those to the test .webidl files. Doing so uncovered an issue where DOMRectInit was referenced in the test files, but did not exist, so we add code to throw in this case, and correct the test file.
TimothyGu
approved these changes
May 20, 2020
lib/parameters.js
Outdated
| overload.operation.arguments[i].default.type === "dictionary"; | ||
| if (isDefaultedDictionary && !ctx.dictionaries.has(idlType.idlType)) { | ||
| throw new Error( | ||
| `The dictionary ${idlType.idlType} was referenced in an argument list, but doesn't exist`); |
There was a problem hiding this comment.
Couldn't it also be another class of errors: the default value is incorrectly set to be {}?
There was a problem hiding this comment.
Fair point. So, maybe something like "The argument X was defaulted to {}, but there is no dictionary named Y".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Web IDL these days, optional dictionary arguments must have a trailing "= {}". This adds those to the test .webidl files. Doing so uncovered an issue where DOMRectInit was referenced in the test files, but did not exist, so we add code to throw in this case, and correct the test file.