Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create sync iterators in the correct realm #234

Merged
merged 2 commits into from
Mar 20, 2021
Merged

Create sync iterators in the correct realm #234

merged 2 commits into from
Mar 20, 2021

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Mar 1, 2021

@ExE-Boss ExE-Boss mentioned this pull request Mar 1, 2021
Open
@ExE-Boss ExE-Boss force-pushed the feat/use-correct-iterator-prototype branch 4 times, most recently from e512756 to 5ff280c Compare March 3, 2021 10:55
domenic
domenic requested changes Mar 7, 2021
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this; it seems like a good approach. There's some unrelated changes that don't belong in this PR, and some over-defensive coding that we should remove.

lib/constructs/interface.js Outdated Show resolved Hide resolved
lib/constructs/interface.js Outdated Show resolved Hide resolved
lib/output/utils.js Outdated Show resolved Hide resolved
lib/output/utils.js Outdated Show resolved Hide resolved
lib/output/utils.js Outdated Show resolved Hide resolved
lib/output/utils.js Outdated Show resolved Hide resolved
lib/constructs/interface.js Show resolved Hide resolved
lib/output/utils.js Show resolved Hide resolved
@ExE-Boss ExE-Boss force-pushed the feat/use-correct-iterator-prototype branch from 5ff280c to fbcaa14 Compare March 9, 2021 18:04
@ExE-Boss ExE-Boss force-pushed the feat/use-correct-iterator-prototype branch from fbcaa14 to 769cc35 Compare March 9, 2021 18:07
@domenic domenic merged commit 8e121c1 into jsdom:master Mar 20, 2021
@ExE-Boss ExE-Boss deleted the feat/use-correct-iterator-prototype branch March 20, 2021 21:38
This was referenced Mar 20, 2021
Merged
Merged
@ninevra ninevra mentioned this pull request Jun 24, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ExE-Boss @domenic